[WIP] BROOKLYN-535: restarter policy when entity stopping #829
+149
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouron
reviewed
Sep 29, 2017
There was a problem hiding this comment.
I know this is marked as WIP, but I tested it and it failed for 2 reasons:
- the missing
return(see my comment) - the expected state set to
on-firewhere it should be stopped. There is a discussion to fix this on the mailing list
But once those are fixed, it should be good to go 👍
| @@ -133,6 +135,10 @@ protected synchronized void onDetectedFailure(SensorEvent<Object> event) { | |||
| LOG.warn("ServiceRestarter suspended, so not acting on failure detected at "+entity+" ("+event.getValue()+")"); | |||
| return; | |||
| } | |||
| if (isEntityStopping()) { | |||
| highlightViolation("Failure detected but entity stopping"); | |||
There was a problem hiding this comment.
Should we highlight the violation here? I guess the question is more: is it really a violation when we are in a stopping state?
| @@ -133,6 +135,10 @@ protected synchronized void onDetectedFailure(SensorEvent<Object> event) { | |||
| LOG.warn("ServiceRestarter suspended, so not acting on failure detected at "+entity+" ("+event.getValue()+")"); | |||
| return; | |||
| } | |||
| if (isEntityStopping()) { | |||
| highlightViolation("Failure detected but entity stopping"); | |||
| LOG.info("Entity stopping, so ServiceRestarter not acting on failure detected at "+entity+" ("+event.getValue()+")"); | |||
|
@aledsage Do you think you can look at my comments above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/BROOKLYN-534